Fatal error on activation

mulyadi · August 11, 2021, 3:15pm

Tried to activate this plugin on a new site, but it caused a fatal error.

leonstafford · August 11, 2021, 11:17pm

may be an out of date version? Latest development version has no code on that line:

leonstafford/static-html-output/blob/develop/src/Options.php#L141

    
      
          
          
    $this->statichtmloutput_options = $options;
              $this->statichtmloutput_option_key = $option_key;
          }
          
          
/**
           * @param mixed[] $value
           */
          public function __set( string $name, $value ) : Options {
              $this->statichtmloutput_options[ $name ] = $value;
          
          
    // NOTE: this is required, not certain why, investigate
              // and make more intuitive
              return $this;
          }
          
          
/**
           * @param mixed $value
           */
          public function setOption( string $name, $value ) : Options {
              return $this->__set( $name, $value );

mulyadi · August 12, 2021, 3:56am

deleted and uninstalled with the latest version.
still the same fatal error.

using the v.6.6.21 version that i downloaded the latest plugin from here:
Static HTML Output: WordPress Static Site Generator Plugin | Thanks for donating!

mulyadi · August 13, 2021, 11:17am

deployed a new server, on apache, today.
got the same fatal error.

mulyadi · August 14, 2021, 11:09am

the issue is not localized.
tried just now on local wp, and the error is still the same.
I’m using PHP 8 and wp 58 on apache, and the first one was on nginx.

leonstafford · August 14, 2021, 12:47pm

OK, let me quickly try on a PHP 8 instance and get back to you

leonstafford · August 14, 2021, 12:49pm

OK, @mulyadi, sorry that took so long for me to look into properly - didn’t have a chance earlier in week.

I confirm I was able to reproduce the issue in my PHP 8 instance with Static HTML Output.

Will file an issue and get it fixed

leonstafford · August 14, 2021, 12:52pm

Ugh, this is very sad - I reported it too long ago:

leonstafford · August 14, 2021, 1:28pm

@mulyadi thanks for your patience. I’ve fixed the issue preventing activation in PHP 8 in github now. There’s a few other little errors/warnings I’m seeing, I’ll fix those up, then share you a zip here to test.

mulyadi · August 14, 2021, 1:39pm

thanks man.
really appreciate this, as im actually moving to a new server, and really expecting this to work.

leonstafford · August 14, 2021, 1:56pm

Here we go, please let me know how this goes.

I should be more responsive for plugin development issues again now

https://github.com/leonstafford/static-html-output/files/6986564/shop-php8-mulyadi.zip

mulyadi · August 15, 2021, 8:53am

thanks @leonstafford.
i managed to activate it.
will let you know about the transfer result.

mulyadi · August 15, 2021, 2:44pm

transferred one/homepage, and the result is not great.
things that I noticed:

nav bar is missing/incorrect
hero image is not stretched/full width
footer is also not stretched/full width

the result from the latest plugin is:
https://611926d54eba5f7bfc8e8248–silverbackwolves.netlify.app/

it should be like this:
https://www.silverbackwolves.com/

leonstafford · August 15, 2021, 2:59pm

all of these are 301’ing to main domain’s homepage… should all be trying to load from netlify?

did you set your WP site URL to the netlify one before publishing?

NATJDTD · November 25, 2021, 6:59am

Hi Leon!

Since yesterday I use PHP 8.0.12 on WP 5.8.2 with Static HTML Output (Version 6.6.21) getting the same fatal error as described above.

Since mulyadi hasn’t replied to your last comment, is there anything else you can help with this issue?

Thx!

leonstafford · November 25, 2021, 8:07am

Hi @NATJDTD are you using last zip installer or from GitHub source code? I believe PHP 8 support should be fine in latest source code and https://lokl.dev is ready, but needs a new release.

I’ll try to prioritise getting some new releases out for all projects, but may not be for another week at least.

NATJDTD · November 25, 2021, 3:56pm

Meanwhile I used the Version 6.6.23-dev via the provided zip-file.

I could activate without getting any errors but unfortunately the crawl (of my 16 URLs) stopped with the message “Failed during “”, please check your Export Log from Logs tab or ask on the support forum.”. The export log is empty.

Next thing I did was clearing the deploy cache but still the same.

Any ideas?

NATJDTD · December 2, 2021, 3:30pm

Hi Leon,

I had to downgrade PHP since it caused several issues on other plugins as well. But still, PHP 8.x - as you yourself experienced - has some issues with your - very much appreciated plugin.

I got the tip it might have something to do with deactivated functions in PHP 8.x which caused in earlier versions “just” a warning but now a fatal error.

Still one day I’ll have and want to upgrade to PHP 8.x.

CODEC · July 21, 2023, 3:50am

Thanks Man, finally I can activate the plugin.